Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dev quickstart guide #733

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Problem:

  • Out of date (the referenced manifests files were changed).
  • Instructions have to be modified before using.

Solution:

  • Use the new manifest file.
  • Simplify instructions so that a developer can just copy paste them without modification.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pleshakov pleshakov requested a review from a team as a code owner June 9, 2023 15:59
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 9, 2023
docs/developer/quickstart.md Outdated Show resolved Hide resolved
docs/developer/quickstart.md Outdated Show resolved Hide resolved
pleshakov added 2 commits June 9, 2023 13:51
Problem:
- Out of date (the referenced manifests files were changed).
- Instructions have to be modified before using.

Solution:
- Use the new manifest file.
- Simplify instructions so that a developer can just copy paste them
without modification.
@pleshakov pleshakov force-pushed the documentation/update-dev-quickstart branch from a4046d4 to 9f23e63 Compare June 9, 2023 19:51
@pleshakov pleshakov requested a review from kate-osborn June 9, 2023 19:52
@pleshakov pleshakov merged commit 1e2d5dd into nginx:main Jun 9, 2023
@pleshakov pleshakov deleted the documentation/update-dev-quickstart branch June 9, 2023 20:00
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Problem:
- Out of date (the referenced manifests files were changed).
- Instructions have to be modified before using.

Solution:
- Use the new manifest file.
- Simplify instructions so that a developer can just copy paste them
without modification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants