Adding CLI validation #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5yacobucci
commented
Nov 14, 2021
f5yacobucci
commented
Nov 14, 2021
|
I'm leaning towards removing any flexibility. It MUST validate as DOMAIN/NS/NAME. Makes expectations and comparisons easier later. Will update. |
f5yacobucci
force-pushed
the
cli-validation
branch
from
5d9b3a3 to
41a5d7b
Compare
f5yacobucci
commented
Nov 17, 2021
pleshakov
reviewed
Nov 17, 2021
f5yacobucci
force-pushed
the
cli-validation
branch
from
46f6b35 to
dfa955d
Compare
pleshakov
approved these changes
Nov 18, 2021
Validate input parameter. Users can input entire DOMAIN/NS/NAME path, or leave some elements off. Gateway will use defaults for missing elements.
- Making domain our API group
- Removed superfluous 'required' arg to GatewayControllerParam
- Single return Validator
- Reworked argument validators
- standardized output
- no mixed structured and unstructured logging to stdout for arguments
- added Must validator (exists on error)
- param validator dynamically gets its value, only arguments are
external constraints
Table testing Stderr Squash
f5yacobucci
force-pushed
the
cli-validation
branch
from
1fd3d91 to
ed4ae77
Compare
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
* Adding CLI validation Validate input parameter. Users can input entire DOMAIN/NS/NAME path, or leave some elements off. Gateway will require all elements. Created Validator pattern. Each argument requiring Validation should provide a Validator. The callback will be provided a FlagSet for referencing other arguments and the particular flag value for validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate input parameter.
Users must input entire DOMAIN/NS/NAME path off.