Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging improvements, second try #113

Merged
merged 4 commits into from
Jan 4, 2025
Merged

Logging improvements, second try #113

merged 4 commits into from
Jan 4, 2025

Conversation

bavshin-f5
Copy link
Member

@bavshin-f5 bavshin-f5 commented Dec 27, 2024 •
edited
Loading

Less ambitious attempt to rewrite the logger.

Two goals for this PR:

  • add ngx_log_error!/ngx_log_conf_error macros
  • avoid allocations in the logger

@bavshin-f5 bavshin-f5 mentioned this pull request Dec 27, 2024
Merged
7 tasks
@bavshin-f5 bavshin-f5 added this to the 0.5.0 milestone Jan 2, 2025
xeioex
xeioex reviewed Jan 3, 2025
View reviewed changes
src/log.rs Outdated Show resolved Hide resolved
@bavshin-f5 bavshin-f5 marked this pull request as ready for review January 3, 2025 08:31
xeioex
xeioex approved these changes Jan 3, 2025
View reviewed changes
Copy link

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/log.rs Outdated Show resolved Hide resolved
This was linked to issues Jan 4, 2025
Crash in Error Handling in upstream.rs in examples #92
Closed
Provide more logging macros #47
Closed
@bavshin-f5 bavshin-f5 merged commit 77e1b5b into nginx:master Jan 4, 2025
8 of 10 checks passed
@bavshin-f5 bavshin-f5 deleted the logging-v2 branch January 4, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeioex xeioex xeioex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Crash in Error Handling in upstream.rs in examples Provide more logging macros
2 participants
@bavshin-f5 @xeioex