Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove legacy feedback form links and layouts #108

Merged
merged 3 commits into from
Jan 15, 2025
Merged

feat: remove legacy feedback form links and layouts #108

merged 3 commits into from
Jan 15, 2025

Conversation

LukeBillington
Copy link
Member

@LukeBillington LukeBillington commented Jan 8, 2025 •
edited
Loading

Proposed changes

Removes feedback footer link in theme along with supplemental page layouts.

This PR is in-tandem with #1570 in the docs repo.

Closes #284 when both are merged.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@LukeBillington LukeBillington marked this pull request as ready for review January 8, 2025 21:58
ADubhlaoich
ADubhlaoich approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved the paired PR, too.

@nginx-jack nginx-jack self-requested a review January 15, 2025 11:35
@nginx-jack nginx-jack mentioned this pull request Jan 15, 2025
Merged
@nginx-jack nginx-jack merged commit 71984f6 into main Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nginx-jack nginx-jack nginx-jack approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@Jcahilltorre Jcahilltorre Awaiting requested review from Jcahilltorre Jcahilltorre is a code owner

@travisamartin travisamartin Awaiting requested review from travisamartin travisamartin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukeBillington @ADubhlaoich @nginx-jack