Store: Add a few objectives for Store's data touched/fetched amount a…

…nd sizes (thanos-io#5819) * Add a few objectives for Store's data touched/fetched The intent is to provide some metrics that will help inform users when setting values for the flags `store.grpc.series-sample-limit` and `store.grpc.touched-series-limit`. Signed-off-by: Douglas Camata <[email protected]> * Update CHANGELOG Signed-off-by: Douglas Camata <[email protected]> * Update some metric's help text Co-authored-by: Moad Zardab <[email protected]> Signed-off-by: Douglas Camata <[email protected]> * Remove quantiles from redundant metric Signed-off-by: Douglas Camata <[email protected]> * Fix spelling Signed-off-by: Douglas Camata <[email protected]> * Fix some metric help texts Signed-off-by: Douglas Camata <[email protected]> Signed-off-by: Douglas Camata <[email protected]> Co-authored-by: Moad Zardab <[email protected]>
ngraham20 · May 18, 2023 · 02cf7db · 02cf7db
1 parent 2ddc834
commit 02cf7db
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -35,6 +35,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
 ### Removed
 
 - [#5824](https://github.com/thanos-io/thanos/pull/5824) Mixin: Remove noisy `ThanosReceiveTrafficBelowThreshold` alert.
+- [#5819](https://github.com/thanos-io/thanos/pull/5819) Store: Add a few objectives for Store's data touched/fetched amount and sizes. They are: 50, 95, and 99 quantiles.
 
 ## [v0.29.0](https://github.com/thanos-io/thanos/tree/release-0.29) - 2022.11.03
 

diff --git a/pkg/store/bucket.go b/pkg/store/bucket.go
@@ -168,21 +168,25 @@ func newBucketStoreMetrics(reg prometheus.Registerer) *bucketStoreMetrics {
 	})
 
 	m.seriesDataTouched = promauto.With(reg).NewSummaryVec(prometheus.SummaryOpts{
-		Name: "thanos_bucket_store_series_data_touched",
-		Help: "How many items of a data type in a block were touched for a single series request.",
+		Name:       "thanos_bucket_store_series_data_touched",
+		Help:       "Number of items of a data type touched to fulfill a single Store API series request.",
+		Objectives: map[float64]float64{0.50: 0.1, 0.95: 0.1, 0.99: 0.001},
 	}, []string{"data_type"})
 	m.seriesDataFetched = promauto.With(reg).NewSummaryVec(prometheus.SummaryOpts{
-		Name: "thanos_bucket_store_series_data_fetched",
-		Help: "How many items of a data type in a block were fetched for a single series request.",
+		Name:       "thanos_bucket_store_series_data_fetched",
+		Help:       "Number of items of a data type retrieved to fulfill a single Store API series request.",
+		Objectives: map[float64]float64{0.50: 0.1, 0.95: 0.1, 0.99: 0.001},
 	}, []string{"data_type"})
 
 	m.seriesDataSizeTouched = promauto.With(reg).NewSummaryVec(prometheus.SummaryOpts{
-		Name: "thanos_bucket_store_series_data_size_touched_bytes",
-		Help: "Size of all items of a data type in a block were touched for a single series request.",
+		Name:       "thanos_bucket_store_series_data_size_touched_bytes",
+		Help:       "Total size of items of a data type touched to fulfill a single Store API series request in Bytes.",
+		Objectives: map[float64]float64{0.50: 0.1, 0.95: 0.1, 0.99: 0.001},
 	}, []string{"data_type"})
 	m.seriesDataSizeFetched = promauto.With(reg).NewSummaryVec(prometheus.SummaryOpts{
-		Name: "thanos_bucket_store_series_data_size_fetched_bytes",
-		Help: "Size of all items of a data type in a block were fetched for a single series request.",
+		Name:       "thanos_bucket_store_series_data_size_fetched_bytes",
+		Help:       "Total size of items of a data type fetched to fulfill a single Store API series request in Bytes.",
+		Objectives: map[float64]float64{0.50: 0.1, 0.95: 0.1, 0.99: 0.001},
 	}, []string{"data_type"})
 
 	m.seriesBlocksQueried = promauto.With(reg).NewSummary(prometheus.SummaryOpts{