Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: allows_pooling boolean defaults false #189

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Conversation

warrn
Copy link
Contributor

@warrn warrn commented Sep 20, 2024

No description provided.

@warrn warrn self-assigned this Sep 20, 2024
config/allows_pooling.go Outdated Show resolved Hide resolved
@warrn warrn requested a review from jrobsonchase September 20, 2024 18:13
config/labeled.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jrobsonchase jrobsonchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop the LabeledTunnelOption interface since it won't be supported there, but otherwise lgtm 👍

warrn and others added 3 commits September 23, 2024 14:52
Co-authored-by: Josh Robson Chase <[email protected]>
Co-authored-by: Josh Robson Chase <[email protected]>
Co-authored-by: Josh Robson Chase <[email protected]>
@warrn warrn marked this pull request as ready for review September 23, 2024 19:05
@warrn warrn merged commit 43a9f8c into main Sep 23, 2024
2 checks passed
@warrn warrn deleted the warrn/allows_pooling branch September 23, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants