Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nippy version to 3.1.1 #104

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

edporras
Copy link
Collaborator

As suggested by Nippy's author. See

https://github.com/ptaoussanis/nippy

@edporras edporras requested a review from ngrunwald August 13, 2021 12:00
@edporras edporras self-assigned this Aug 13, 2021
@edporras edporras changed the base branch from master to devel August 13, 2021 12:01
@edporras edporras marked this pull request as draft August 13, 2021 12:03
@edporras edporras marked this pull request as ready for review August 13, 2021 12:10
Versions after 2.14.0 required a breaking change due to security
advisories (see taoensso/nippy#130). The
fix requires explicit declaration of the types that are safe to
thaw.
@edporras edporras force-pushed the ep-dsplash-bump-nippy branch from 3e00784 to c931c4c Compare August 13, 2021 13:33
@ngrunwald ngrunwald merged commit ec47f0a into ngrunwald:devel Aug 14, 2021
domparry added a commit to SimplyFinServices/datasplash that referenced this pull request Sep 2, 2021
@domparry
Copy link
Contributor

domparry commented Sep 2, 2021

This is a breaking change. For example, datastore delete no longer works since com.google.datastore.v1.Entity is not in the default-thaw-serializable-allowlist. I'm not sure what other cases are broken. I have reverted this in my branch and all is working again.

@edporras edporras deleted the ep-dsplash-bump-nippy branch May 15, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants