feat(eslint-plugin): add new rule require-super-ondestroy

ngrx · Dec 9, 2024 · c9379a3 · c9379a3
1 parent 2c1fd97
commit c9379a3
Showing 1 changed file with 24 additions and 0 deletions.
diff --git a/modules/eslint-plugin/spec/rules/component-store/require-super-ondestroy.spec.ts b/modules/eslint-plugin/spec/rules/component-store/require-super-ondestroy.spec.ts
@@ -61,6 +61,18 @@ class BooksStore extends ComponentStore<BooksState> implements OnDestroy
     super.ngOnDestroy();
     this.cleanUp();
   }
+}`,
+  `
+import { ComponentStore } from '../components/component-store';
+
+class BooksStore extends ComponentStore implements OnDestroy
+{
+  cleanUp() {}
+
+  override ngOnDestroy(): void {
+    this.cleanUp();
+    super.ngOnDestroy();
+  }
 }`,
 ];
 
@@ -101,6 +113,18 @@ class BooksStore extends ComponentStore<BooksState> implements OnDestroy {
            ~~~~~~~~~~~ [${messageId}]
     super.get();
   }
+}`),
+  fromFixture(`
+import { ComponentStore } from '../components/component-store';
+
+class BooksStore extends ComponentStore implements OnDestroy
+{
+  cleanUp() {}
+
+  override ngOnDestroy(): void {
+           ~~~~~~~~~~~ [${messageId}]
+    this.cleanUp();
+  }
 }`),
 ];