fix(store): correctly infer action group events defined as empty obje…

…ct (#3833)
ngrx · Apr 15, 2023 · dc78447 · dc78447
1 parent fd8f347
commit dc78447
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 3 deletions.
diff --git a/modules/store/spec/types/action_group_creator.spec.ts b/modules/store/spec/types/action_group_creator.spec.ts
@@ -70,6 +70,32 @@ describe('createActionGroup', () => {
       });
     });
 
+    describe('events', () => {
+      it('should infer events dictionary', () => {
+        expectSnippet(`
+          const authApiActions = createActionGroup({
+            source: 'Auth API',
+            events: {
+              'Login Success': props<{ token: string; }>,
+              'Login Failure': (message: string) => ({ message }),
+            },
+          });
+        `).toInfer(
+          'authApiActions',
+          "ActionGroup<\"Auth API\", { 'Login Success': () => ActionCreatorProps<{ token: string; }>; 'Login Failure': (message: string) => { message: string; }; }>"
+        );
+      });
+
+      it('should infer events defined as an empty object', () => {
+        expectSnippet(`
+          const authApiActions = createActionGroup({
+            source: 'Auth API',
+            events: {},
+          });
+        `).toInfer('authApiActions', 'ActionGroup<"Auth API", {}>');
+      });
+    });
+
     describe('event name', () => {
       it('should create action name by camel casing the event name', () => {
         expectSnippet(`

diff --git a/modules/store/src/action_group_creator_models.ts b/modules/store/src/action_group_creator_models.ts
@@ -103,9 +103,11 @@ export interface ActionGroupConfig<
   Events extends Record<string, ActionCreatorProps<unknown> | Creator>
 > {
   source: Source & StringLiteralCheck<Source, 'source'>;
-  events: {
-    [EventName in keyof Events]: Events[EventName] &
-      EmptyStringCheck<EventName & string, 'event name'> &
+  events: Events & {
+    [EventName in keyof Events]: EmptyStringCheck<
+      EventName & string,
+      'event name'
+    > &
       StringLiteralCheck<EventName & string, 'event name'> &
       ForbiddenCharactersCheck<EventName & string, 'event name'> &
       UniqueEventNameCheck<keyof Events & string, EventName & string> &