Skip to content

Commit

Permalink
fix(data): HttpOptions removes options passed to execute via a overri…
Browse files Browse the repository at this point in the history
…dden methods in a custom DataService

Closes #3794
 - fix broken merge
  • Loading branch information
cam-m committed Mar 3, 2023
1 parent 639af31 commit f155060
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions modules/data/spec/dataservices/default-data.service.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,8 @@ describe('DefaultDataService', () => {

// Respond with the mock heroes
req.flush(expectedHeroes);

});

it('should support custom data services that provide their own http options to execute', (done) => {
const httpOptions: HttpOptions = {
httpParams: { fromString: 'name=B' },
Expand All @@ -387,7 +388,7 @@ describe('DefaultDataService', () => {
// Respond with the mock heroes
req.flush(expectedHeroes);
});

it('should be OK returning no heroes', (done) => {
service.getWithQuery({ name: 'B' }).subscribe((heroes) => {
expect(heroes.length).toEqual(0);
Expand Down

0 comments on commit f155060

Please sign in to comment.