Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schematics: Bump platform version for ng-add schematics #1489

Closed
brandonroberts opened this issue Dec 27, 2018 · 0 comments · Fixed by #1527
Closed

Schematics: Bump platform version for ng-add schematics #1489

brandonroberts opened this issue Dec 27, 2018 · 0 comments · Fixed by #1527
Labels
Accepting PRs Good First Issue Good issue for first-time contributor Project: Schematics

Comments

@brandonroberts
Copy link
Member

Minimal reproduction of the bug/regression with instructions:

Expected behavior:

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):

Other information:

I would be willing to submit a PR to fix this issue

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

Our platformVersion is still locked to ^6.0.0 and should be ^7.0.0

https://github.com/ngrx/platform/blob/master/modules/schematics-core/utility/libs-version.ts
ngfelixl added a commit to ngfelixl/platform that referenced this issue Jan 1, 2019
@ngfelixl
refactor(schematics): update platform version to ^7.0.0
e2340bf 
Update the platform version for each module in /schematics-core/utitlity
to version ^7.0.0

Closes ngrx#1489
@wesleygrimes wesleygrimes mentioned this issue Jan 24, 2019
Merged
3 tasks
brandonroberts pushed a commit that referenced this issue Jan 25, 2019
@wesleygrimes @brandonroberts
feat(schematics): bump platformVersion to ^7.0.0 per issue #1489 (#1527)
a71aa71 
Closes #1489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Good First Issue Good issue for first-time contributor Project: Schematics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(schematics): bump platformVersion to ^7.0.0 per issue #1489
1 participant
@brandonroberts