Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Remove GitHub link from top nav #2185

Closed
brandonroberts opened this issue Oct 28, 2019 · 0 comments · Fixed by #2188
Closed

Docs: Remove GitHub link from top nav #2185

brandonroberts opened this issue Oct 28, 2019 · 0 comments · Fixed by #2188
Labels
Accepting PRs Comp: Docs Good First Issue Good issue for first-time contributor

Comments

@brandonroberts
Copy link
Member

We have a GitHub link and icon in the top nav.
@brandonroberts brandonroberts added Comp: Docs Accepting PRs Good First Issue Good issue for first-time contributor labels Oct 28, 2019
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this issue Oct 29, 2019
docs: remove github link from top nav
f7e58d5 
Closes ngrx#2185
@jordanpowell88 jordanpowell88 mentioned this issue Oct 29, 2019
Merged
2 tasks
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this issue Nov 5, 2019
docs: remove github link from navigation
f8fdaac 
Closes ngrx#2185
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this issue Nov 5, 2019
docs: remove github link from navigation
10d0007 
Closes ngrx#2185
brandonroberts pushed a commit that referenced this issue Nov 5, 2019
@jordanpowell88 @brandonroberts
docs: remove github link from navigation (#2188)
6f40060 
Closes #2185
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this issue Nov 8, 2019
@jordanpowell88
Merge branch 'master' of https://github.com/ngrx/platform
c7a296f 
refactor(effects): refactor types in effects, expose metadata key for createEffect

refactor(example): close sidenav when logoutConfirmation is dispatched (ngrx#2189)

Closes ngrx#2186

docs: remove github link from navigation (ngrx#2188)

Closes ngrx#2185

feat(schematics): add message prompts for individual schematics (ngrx#2143)

test(store): fix flaky integration test (ngrx#2209)
jordanpowell88 added a commit to jordanpowell88/platform that referenced this issue Nov 14, 2019
@jordanpowell88
docs: remove github link from navigation (ngrx#2188)
016a19b 
Closes ngrx#2185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Comp: Docs Good First Issue Good issue for first-time contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: remove github link from navigation jordanpowell88/platform
1 participant
@brandonroberts