-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(data): correctly handle HttpOptions when provided #3795
Conversation
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you resolve the merge conflicts please
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the description so it closes the correct issue.
I also noticed there are many commits within this PR, could you rebase those so it only includes the commit with the changes please?
…dden methods in a custom DataService Closes ngrx#3794
Apologies, reused my branch from the original work for this, still new to PRs. Should be ok now, thanks! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Http Options are incorrectly merged when users extend the DefaultDataService and override a method, adding http options to the execute call.
Closes #3794
What is the new behavior?
Http Options are correctly merged
Does this PR introduce a breaking change?
Other information