Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): correctly handle HttpOptions when provided #3795

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

cam-m
Copy link
Contributor

@cam-m cam-m commented Mar 3, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Http Options are incorrectly merged when users extend the DefaultDataService and override a method, adding http options to the execute call.

Closes #3794

What is the new behavior?

Http Options are correctly merged

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Mar 3, 2023

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 9c104d2
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/64113a6ffecc33000855d012

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve the merge conflicts please

@cam-m
Copy link
Contributor Author

cam-m commented Mar 4, 2023

done

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the description so it closes the correct issue.
I also noticed there are many commits within this PR, could you rebase those so it only includes the commit with the changes please?

@cam-m
Copy link
Contributor Author

cam-m commented Mar 15, 2023

I updated the description so it closes the correct issue. I also noticed there are many commits within this PR, could you rebase those so it only includes the commit with the changes please?

Apologies, reused my branch from the original work for this, still new to PRs. Should be ok now, thanks!

@brandonroberts brandonroberts changed the title Bug 3794 fix fix(data): correctly handle HttpOptions when provided Mar 15, 2023
@brandonroberts brandonroberts merged commit cbdf524 into ngrx:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpOptions removes options passed to execute via a overridden methods in a custom DataService
3 participants