Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data example app #4586

Closed
2 tasks
timdeschryver opened this issue Nov 13, 2024 · 1 comment · Fixed by #4594
Closed
2 tasks

Remove data example app #4586

timdeschryver opened this issue Nov 13, 2024 · 1 comment · Fixed by #4594
Labels
Accepting PRs Good First Issue Good issue for first-time contributor

Comments

@timdeschryver
Copy link
Member

Which @ngrx/* package(s) are relevant/related to the feature request?

data

Information

Because @ngrx/data is in maintenance mode and we don't really do much with the data example app, we can safely remove it.
This makes it less time-consuming to upgrade to latest versions (e.g. migrating to standalone).

Therefore, https://github.com/ngrx/platform/tree/main/projects/data-example-app (and the corresponding NX project) can be removed.

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@timdeschryver timdeschryver added Accepting PRs Good First Issue Good issue for first-time contributor labels Nov 13, 2024
pawel-twardziak added a commit to pawel-twardziak/ngrx-platform that referenced this issue Nov 14, 2024
@pawel-twardziak
Copy link
Contributor

pawel-twardziak commented Nov 14, 2024

Not sure if there is anything else is to be done despite the removal, is there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs Good First Issue Good issue for first-time contributor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants