Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup metadata and add types #1131

Merged
merged 2 commits into from
Jul 5, 2018
Merged

cleanup metadata and add types #1131

merged 2 commits into from
Jul 5, 2018

Conversation

alex-okrushko
Copy link
Member

@alex-okrushko alex-okrushko commented Jun 14, 2018

Remove leftover of Reflect
remove a bunch of any types
general cleanup

for #623

@robwormald @brandonroberts @MikeRyanDev Any reason in particular why METADATA_KEY is added to sourceProto.constructor ( aka instance.constructor) instead of simply to the instance?
This prevents me from removing the remaining constructor as any pieces because constructor has type of Function.

I've experimented with putting it just on instance at Firebase and it appears to work just fine, but maybe there is some background that I'm not aware of.

@coveralls
Copy link

coveralls commented Jun 14, 2018

Coverage Status

Coverage increased (+0.007%) to 87.978% when pulling 8b64152 on alex-okrushko:effects-metadata into 55a0488 on ngrx:master.

@brandonroberts brandonroberts merged commit e7ae8a2 into ngrx:master Jul 5, 2018
@alex-okrushko alex-okrushko deleted the effects-metadata branch July 5, 2018 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants