Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove leftover of
Reflect
remove a bunch of
any
typesgeneral cleanup
for #623
@robwormald @brandonroberts @MikeRyanDev Any reason in particular why
METADATA_KEY
is added tosourceProto.constructor
( akainstance.constructor
) instead of simply to theinstance
?This prevents me from removing the remaining
constructor as any
pieces becauseconstructor
has type ofFunction
.I've experimented with putting it just on
instance
at Firebase and it appears to work just fine, but maybe there is some background that I'm not aware of.