Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Example): remove ngrx-store-freeze #1633

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

When #1613 gets merged we have mutation checks built in

When #1613 gets merged we have mutation checks built in
@ngrxbot
Copy link
Collaborator

ngrxbot commented Mar 17, 2019

Preview docs changes for cba6676 at https://previews.ngrx.io/pr1633-cba6676/

1 similar comment
@ngrxbot
Copy link
Collaborator

ngrxbot commented Mar 17, 2019

Preview docs changes for cba6676 at https://previews.ngrx.io/pr1633-cba6676/

@timdeschryver
Copy link
Member Author

Since runtime checks are now opt-in, we should enable the immutably check when #1613 gets merged.

@brandonroberts brandonroberts merged commit 29e7885 into master Apr 1, 2019
@brandonroberts brandonroberts deleted the pr/remove-store-freeze branch April 1, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants