Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(effects): inline ngrxOnRunEffects type #2208

Merged
merged 1 commit into from
Nov 7, 2019
Merged

refactor(effects): inline ngrxOnRunEffects type #2208

merged 1 commit into from
Nov 7, 2019

Conversation

L2jLiga
Copy link
Contributor

@L2jLiga L2jLiga commented Nov 5, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

JetBrains WebStorm can not recognize that ngrxOnRunEffects is implements OnRunEffects
image

What is the new behavior?

JetBrains WebStorm can recognize that ngrxOnRunEffects is implements OnRunEffects
image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@brandonroberts
Copy link
Member

This would be a breaking change as you're removing something from the public API that may be in use.

@L2jLiga
Copy link
Contributor Author

L2jLiga commented Nov 7, 2019

I've checked, onRunEffectsFn isn't exported as public API, is it?

Copy link
Member

@alex-okrushko alex-okrushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. Very well done.

@brandonroberts brandonroberts merged commit 50d1c74 into ngrx:master Nov 7, 2019
@L2jLiga L2jLiga deleted the inline-ngrx-on-run-effects-type branch November 7, 2019 14:55
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants