-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(component): update usage of TestBed.get to TestBed.inject #2311
Conversation
Preview docs changes for 8348155 at https://previews.ngrx.io/pr2311-8348155/ |
Not sure why ci is failing. |
@timdeschryver can you review it.? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm currently a bit busy but I'll get to it in a couple of days.
You can take a look at the build to see the errors, if you scroll to the bottom of the command output:
https://circleci.com/gh/ngrx/platform/20647?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
https://circleci.com/gh/ngrx/platform/20648?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
https://circleci.com/gh/ngrx/platform/20651?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
Thanks for the PR @sumitparakh! None of the files in the |
And the tests under |
6adf6eb
to
20132cc
Compare
There are still lots of files changed that shouldn't be. Please revert those changes completely, so only the actual files that need to be touched are changed. |
test cases updated in content folder only Closes ngrx#2240
5224a22
to
8348155
Compare
@brandonroberts Done! |
Thanks @sumitparakh! |
angular 9 compatibillity changes for TestBed
Closes #2240
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information