Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(component): update usage of TestBed.get to TestBed.inject #2311

Merged
merged 1 commit into from
Jan 12, 2020

Conversation

sumitparakh
Copy link
Contributor

@sumitparakh sumitparakh commented Jan 8, 2020

angular 9 compatibillity changes for TestBed

Closes #2240

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Testing compatibility changes for angular 9

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 8, 2020

Preview docs changes for 8348155 at https://previews.ngrx.io/pr2311-8348155/

@sumitparakh sumitparakh marked this pull request as ready for review January 9, 2020 07:53
@sumitparakh
Copy link
Contributor Author

Not sure why ci is failing.

@sumitparakh
Copy link
Contributor Author

@timdeschryver can you review it.?

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timdeschryver timdeschryver added the Needs Cleanup Review changes needed label Jan 9, 2020
@brandonroberts
Copy link
Member

Thanks for the PR @sumitparakh!

None of the files in the /docs folder should be modified. They are deprecated and out of date.

@brandonroberts
Copy link
Member

And the tests under projects/ngrx.io/src should not be modified either. Just the files under projects/ngrx.io/content

@sumitparakh sumitparakh force-pushed the parakh/testBedUpdate branch 2 times, most recently from 6adf6eb to 20132cc Compare January 10, 2020 15:53
@brandonroberts
Copy link
Member

There are still lots of files changed that shouldn't be. Please revert those changes completely, so only the actual files that need to be touched are changed.

test cases updated in content folder only

Closes ngrx#2240
@sumitparakh
Copy link
Contributor Author

There are still lots of files changed that shouldn't be. Please revert those changes completely, so only the actual files that need to be touched are changed.

@brandonroberts Done!

@brandonroberts brandonroberts merged commit 2cc8885 into ngrx:master Jan 12, 2020
@brandonroberts
Copy link
Member

Thanks @sumitparakh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Cleanup Review changes needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform: Update usage of TestBed.get to TestBed.inject
4 participants