Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(data): add entity action guard tests #2390

Merged

Conversation

AdditionAddict
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ x ] Other... Please describe: 

→ added tests

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ x ] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 16, 2020

Preview docs changes for 4a71e7e at https://previews.ngrx.io/pr2390-4a71e7e/

@@ -1,3 +1,344 @@
import { EntityActionGuard, EntityAction, EntityOp } from '../..';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should import from their internal location instead of the root.

@brandonroberts brandonroberts added the Needs Cleanup Review changes needed label Feb 17, 2020
@brandonroberts brandonroberts merged commit a1a282d into ngrx:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Cleanup Review changes needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants