feat(store): add object-style StoreModule.forFeature overload #2821
Conversation
modules/store/spec/modules.spec.ts
Outdated
| @@ -216,4 +216,34 @@ describe(`Store Modules`, () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe(`: Slice-Like paramter`, () => { | |||
There was a problem hiding this comment.
Should it be tested with the real RTK slice as an integration spec?
There was a problem hiding this comment.
I don't think that that is needed.
There was a problem hiding this comment.
That being said, perhaps we could add a recipe to use NgRx with RTK in the future, as a separate PR.
|
Preview docs changes for 2703c2d at https://previews.ngrx.io/pr2821-2703c2d9/ |
|
Thanks @lacolaco! |
|
we'd need to rollback this PR, it's breaking g3 - and any codebase that is still using ViewEngine (the cause itself is my guess). This is what I have: |
|
@lacolaco Would you be able to take a look at it? |
…#2885) * feat(store): add object-style StoreModule.forFeature overload (#2821) Closes #2809 * fix(store): update StoreModule to be compliant with AOT Co-authored-by: Suguru Inatomi <[email protected]>
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #2809
What is the new behavior?
Adding a new overload for
StoreModule.forFeature();Does this PR introduce a breaking change?
Other information
I think my code is not elegant because added overload has a very different shape. I'd like to be commented on codes.