Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(store): add 'Testing without TestBed' example #2836

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@ngrxbot
Copy link
Collaborator

ngrxbot commented Dec 21, 2020

Preview docs changes for bee407d at https://previews.ngrx.io/pr2836-bee407da/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Should we guide the user in how, when and why to use or not to use the TestBed?
This, in a separate PR.

Comment on lines +114 to +115
import { MockStore, provideMockStore } from '@ngrx/store/testing';
import { Injector } from '@angular/core';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: we (try) to import the angular dependencies first.

Suggested change
import { MockStore, provideMockStore } from '@ngrx/store/testing';
import { Injector } from '@angular/core';
import { Injector } from '@angular/core';
import { MockStore, provideMockStore } from '@ngrx/store/testing';

@brandonroberts brandonroberts merged commit 7a806e2 into ngrx:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants