build: update NX #3251
Merged
build: update NX #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview docs changes for b165520 at https://previews.ngrx.io/pr3251-b1655200/ |
|
Yikes, I'll have to take a look at the failing steps. Seems like these are green locally. |
timdeschryver
force-pushed
the
update-nx
branch
from
a70f00c to
030ec38
Compare
timdeschryver
force-pushed
the
update-nx
branch
3 times, most recently
from
dcb8028 to
a19d660
Compare
timdeschryver
force-pushed
the
update-nx
branch
2 times, most recently
from
3dc48d1 to
03ae744
Compare
timdeschryver
force-pushed
the
update-nx
branch
from
03ae744 to
0b0f392
Compare
timdeschryver
commented
Dec 1, 2021
| @@ -113,7 +113,7 @@ jobs: | |||
| # Test | |||
| - run: | |||
| name: Run All Unit Tests | |||
| command: yarn nx run-many --target=test --all | |||
| command: yarn nx run-many --target=test --all --parallel=1 | |||
There was a problem hiding this comment.
Needed to add this to make make the circle ci happy.
Otherwise, the following errors were thrown randomly.
> nx run component:test
Nx could not find process's output. Run the command without --parallel.
> nx run component-store:test
Nx could not find process's output. Run the command without --parallel.
I was under the impression that this was handled by the migration by NX.
@brandonroberts this could maybe be a bug in NX?
There was a problem hiding this comment.
Yea, if it's set in the nx.json, it shouldn't be necessary to manually set it everywhere for CI
timdeschryver
commented
Dec 1, 2021
| @@ -33,6 +33,11 @@ | |||
| { | |||
| "files": ["*.ts"], | |||
| "rules": { | |||
| "@typescript-eslint/no-explicit-any": "off", | |||
There was a problem hiding this comment.
This was bloating the output so I disabled it 😅
brandonroberts
approved these changes
Dec 2, 2021
markostanimirovic
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information
While testing #3245, some tests of the example app weren't working anymore.
With this update, all tests are back to green.
To upgrade, I used the
nx migratecommands.