Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): fix configuration guide link #3480

Merged
merged 1 commit into from
Jul 11, 2022
Merged

fix(eslint-plugin): fix configuration guide link #3480

merged 1 commit into from
Jul 11, 2022

Conversation

yassernasc
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

image

Because of the dot at the end, the link goes to the ngrx.io's Page Not Found message.

What is the new behavior?

fixed :)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link

netlify bot commented Jul 7, 2022

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 5821e5f
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/62cc23ed5ae7c30009c622d4

@@ -41,7 +41,7 @@ Please see ${docs} to configure the NgRx ESLint Plugin.
context.logger.info(`
The NgRx ESLint Plugin is installed and configured with the '${schema.config}' config.

If you want to change the configuration, please see ${docs}.
Check ${docs} if you want to change the configuration.
Copy link
Member

@timdeschryver timdeschryver Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR!
The original sentence is a bit short and bold I think.
What do you think of making it friendly?

Suggested change
Check ${docs} if you want to change the configuration.
Take a look at the docs at ${docs} if you want to change the default configuration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@timdeschryver timdeschryver merged commit 8219b1d into ngrx:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants