fix(component-store): move isInitialized check to queueScheduler context on state update #3492
+30
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
Comment on lines
+243
to
+249
| expect(() => { | ||
| queueScheduler.schedule(() => { | ||
| const componentStore = new ComponentStore({ foo: false }); | ||
| componentStore.patchState({ foo: true }); | ||
| }); | ||
| }).not.toThrow(); |
There was a problem hiding this comment.
this test would fail before this PR
…ext on state update Closes ngrx#2991
markostanimirovic
force-pushed
the
fix/component-store/queue-scheduler
branch
from
cc47494 to
d997c1c
Compare
alex-okrushko
approved these changes
Aug 16, 2022
| throwError(() => new Error(this.notInitializedErrorMessage)) | ||
| ), | ||
| // Push the value into queueScheduler | ||
| observeOn(queueScheduler), |
There was a problem hiding this comment.
I was very confident that observeOn was deprecated in favour of scheduled. Apparently I was dreaming?
There was a problem hiding this comment.
😁 AFAIK, the signature of the of function that accepts scheduler is deprecated in favor of scheduled.
timdeschryver
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #2991
What is the new behavior?
There is no initialization error when ComponentStore initialization and state update are scheduled via
queueScheduler.Does this PR introduce a breaking change?