feat(effects): change the signature of provideEffect #3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The signature of `provideEffects` is changed to expect a spreaded array of effects. BEFORE: `provideEffects` expecteded the effects to be passed as an array. ```ts // single effect provideEffects([MyEffect]) // multiple effects provideEffects([MyEffect, MySecondEffect]) ```ts AFTER: `provideEffects` expects the effects as a spreaded array as argument. ```ts // single effect provideEffects(MyEffect) // multiple effects provideEffects(MyEffect, MySecondEffect) ```ts
✅ Deploy Preview for ngrx-io canceled.
|
alex-okrushko
approved these changes
Sep 24, 2022
markostanimirovic
approved these changes
Sep 29, 2022
3 tasks
|
👍 Cool, I was just looking if anyone already proposed this signature change |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
BREAKING CHANGE:
The signature of
provideEffectsis changed to expect a spreaded array of effects.BEFORE:
provideEffectsexpecteded the effects to be passed as an array.AFTER:
provideEffectsexpects the effects as a spreaded array as argument.