feat(component-store): add a testing library #3646
Conversation
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
brandonroberts
requested review from
alex-okrushko,
timdeschryver and
markostanimirovic
| @@ -1043,5 +1043,8 @@ | |||
| "schematics": {}, | |||
| "tags": [] | |||
| } | |||
| }, | |||
| "cli": { | |||
| "analytics": false | |||
There was a problem hiding this comment.
Revert this, they probably don't want that.
| @@ -0,0 +1,211 @@ | |||
| import { Provider, Type } from '@angular/core'; | |||
| import { TestBed } from '@angular/core/testing'; | |||
| import 'jasmine'; | |||
There was a problem hiding this comment.
Given the hard dep on jasmine here, you'd need to be using Jasmine to use this (which makes sense, given the contribution here).
Does it make sense to put this in
~/modules/component-store/testing/jasmine/xxx/yyy
Imaging that the namespace is..
@ngrx/component-store/testing/jasmine
There was a problem hiding this comment.
I wonder if it makes sense to make this generic; the consumer would pass in a parameter that can create a "spy", and a second one that takes a spy and configures it to return a value.
There was a problem hiding this comment.
Or use a testing framework-agnostic test double library such as Sinon.JS.
| @@ -22,6 +22,7 @@ | |||
| "@ngrx/component-store/schematics-core": [ | |||
| "./modules/component-store/schematics-core" | |||
| ], | |||
| "@ngrx/component-store/testing": ["./modules/component-store/testing"], | |||
There was a problem hiding this comment.
On my earlier note, should we update this here as well?
ngrx/component-store/testing/jasmine
| token: Type<MockComponentStore<T>>; | ||
| } | ||
|
|
||
| interface Constructor<ClassType> { |
There was a problem hiding this comment.
Nit/opt: This interface allows you to infer that a constructor for a given type was passed.
- Should this be "
ConstructorOf<T>" ?
I do not feel strongly, but I did feel like perhaps this might have sounded like a built-in, and it might be good to disambiguate. /shruggie
|
I will close this PR as it has not been updated for a long time. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is no simple unified way that NgRx provides to mock a
ComponentStore; this adds a mocking library with a simple API to facilitate writing tests for components that use theComponentStore.Closes #2767.
What is the new behavior?
Does this PR introduce a breaking change?
Other information