Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router-store): remove deprecated getSelectors method #3816

Conversation

apramendorfer
Copy link
Contributor

Removes deprecated getSelectors method from router-store

Closes #3813

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: removes deprecated method

What is the current behavior?

Closes #3815

What is the new behavior?

The deprecated method getSelectors is removed from router-store

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

Migration script for the renaming of the method is already in place.

Removes deprecated getSelectors method from router-store

Closes ngrx#3813
@netlify
Copy link

netlify bot commented Mar 29, 2023

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit e450898
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/642486f0ee691e0008f776f0

@apramendorfer apramendorfer marked this pull request as ready for review March 29, 2023 19:38
@apramendorfer
Copy link
Contributor Author

This is my first OS contribution, just as a disclaimer 😄

@markostanimirovic markostanimirovic changed the title refactor(router-store): remove deprecated getSelectors method feat(router-store): remove deprecated getSelectors method Mar 29, 2023
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first contribution, that's awesome to hear! 🏆

@brandonroberts brandonroberts merged commit 351a75e into ngrx:master Apr 15, 2023
@brandonroberts
Copy link
Member

Thanks @apramendorfer, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the deprecated getSelectors method
4 participants