-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(effects): add migrator for concatLatestFrom
#4311
feat(effects): add migrator for concatLatestFrom
#4311
Conversation
Adds a migrator for version 18 which replaces all `concatLatestFrom` imports from `@ngrx/effects` to `@ngrx/operators`.
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
@markostanimirovic I'd suggest we make this one first and it will serve as a template for the component-store migrator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The version can be changed to the beta version.
Co-authored-by: Tim Deschryver <[email protected]>
Co-authored-by: Marko Stanimirović <[email protected]>
…hnekamp/ngrx into feat/effects/migrator-operators
@markostanimirovic if possible, I'd like to push the version that includes the fix of #4311 (comment) before this is merged. |
sounds good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rainerhahnekamp !
Adds a migrator for version 18 which
replaces all
concatLatestFrom
importsfrom
@ngrx/effects
to@ngrx/operators
.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
Migration to @ngrx/operators
Closes #4262
What is the new behavior?
Does this PR introduce a breaking change?
Other information