Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Entity): Provide Update at top level import, closes #670 #675

Merged
merged 5 commits into from
Dec 29, 2017
Merged

refactor(Entity): Provide Update at top level import, closes #670 #675

merged 5 commits into from
Dec 29, 2017

Conversation

sandangel
Copy link
Contributor

Reference: #670

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.611% when pulling ea78087 on sandangel:update-type into 95dd2dc on ngrx:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.611% when pulling 62506e6 on sandangel:update-type into 95dd2dc on ngrx:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.611% when pulling 0046184 on sandangel:update-type into 95dd2dc on ngrx:master.

@brandonroberts brandonroberts self-assigned this Dec 28, 2017
brandonroberts
brandonroberts requested changes Dec 28, 2017
View reviewed changes
docs/entity/adapter.md Outdated
@@ -103,6 +103,7 @@ export interface User {
```ts
import { Action } from '@ngrx/store';
import { User } from './user.model';
import { Update } from '@ngrx/entity';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit but will you move this import above the user.model import?

@brandonroberts
Copy link
Member

@sandangel you want to take a stab at updating the entity schematic also?

@sandangel
Copy link
Contributor Author

I will take a look

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.611% when pulling 422e5c1 on sandangel:update-type into 95dd2dc on ngrx:master.

@sandangel
Copy link
Contributor Author

Can you review @brandonroberts

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.611% when pulling ecacd61 on sandangel:update-type into 95dd2dc on ngrx:master.

@brandonroberts brandonroberts merged commit d9b37cd into ngrx:master Dec 29, 2017
@brandonroberts
Copy link
Member

Nice work, thanks!

@shhdgit shhdgit mentioned this pull request Jan 3, 2018
Closed
@sandangel sandangel mentioned this pull request Feb 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees

@brandonroberts brandonroberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandangel @coveralls @brandonroberts