Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #492 - MacOS man #503

Merged
merged 9 commits into from
Jan 16, 2022
Merged

Issue #492 - MacOS man #503

merged 9 commits into from
Jan 16, 2022
+16 −4

Conversation

organom
Copy link
Member

@organom organom commented Nov 26, 2021

MacOS man by default is stored in /usr/local/shared/man/man1 instead of /usr/local/man/man1

@organom
Fixes #492 - macOS man

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3ba828a
@organom organom requested a review from ilyash November 26, 2021 18:24
@organom
Copy link
Member Author

organom commented Nov 28, 2021 •
edited
Loading

@ilyash can you please also try the install both in your mac and linux in order to make sure everything works correctly? thanks :)

@ilyash
Copy link
Member

ilyash commented Nov 30, 2021

@ilyash can you please also try the install both in your mac and linux in order to make sure everything works correctly? thanks :)

As agreed during the weekly, please add tests so that correct installation is tested during/after the build on GitHub

ilyash
ilyash requested changes Nov 30, 2021
View reviewed changes
Copy link
Member

@ilyash ilyash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@organom
Copy link
Member Author

organom commented Dec 6, 2021 •
edited
Loading

@ilyash-b added the tests directly in the makefile at b40e798. Do you have any better idea, or is it ok like this?

Also noticed that this is breaking the docker build, since apparently inside docker:

root@1ecc278a0218:/# man ls
This system has been minimized by removing packages and content that are
not required on a system that users do not log into.

To restore this content, including manpages, you can run the 'unminimize'
command. You will still need to ensure the 'man-db' package is installed.

Any idea for this?

ilyash-b
ilyash-b requested changes Dec 22, 2021
View reviewed changes
@organom organom requested review from ilyash-b and ilyash December 26, 2021 11:58
@organom organom changed the title Fixes #492 - MacOS man Issue #492 - MacOS man Jan 9, 2022
@organom
Copy link
Member Author

organom commented Jan 14, 2022 •
edited
Loading

Man test added to be build, after merge of this, we need to re-adapt PR #524
@ilyash is it ok like this? or we need something else to approve this one ?

ilyash-b
ilyash-b reviewed Jan 16, 2022
View reviewed changes
@organom organom requested a review from ilyash-b January 16, 2022 15:45
@organom
Copy link
Member Author

organom commented Jan 16, 2022

@ilyash-b changes applied, please re-review

@ilyash-b ilyash-b merged commit 5cdb704 into dev Jan 16, 2022
@organom organom deleted the 492-macos-man branch January 16, 2022 16:39
@organom organom mentioned this pull request Jan 16, 2022
Merged
@organom organom mentioned this pull request Jan 28, 2022
Closed
@ryandesign ryandesign mentioned this pull request Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyash ilyash

@ilyash-b ilyash-b

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@organom @ilyash @ilyash-b