Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not workign with the v18.0.0 of the store #788

Closed
vanerleo opened this issue Jun 16, 2024 · 10 comments
Closed

Not workign with the v18.0.0 of the store #788

vanerleo opened this issue Jun 16, 2024 · 10 comments

Comments

@vanerleo
Copy link

vanerleo commented Jun 16, 2024

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x ] Feature request
[ ] Documentation issue or request
[ ] Support request => https://github.com/ngxs/store/blob/master/CONTRIBUTING.md
[ ] Other... Please describe:

Current behavior

Throws error at compile time

✘ [ERROR] No matching export in "node_modules/@ngxs/store/fesm2022/ngxs-store.mjs" for import "ensureStoreMetadata"

    node_modules/@ngxs-labs/emitter/fesm2020/ngxs-labs-emitter.mjs:1:9:
      1 │ import { ensureStoreMetadata, Store, getActionTypeFromInstance } from '@ngxs/store';

Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Throws error at compile time

Environment


Libs:
- @angular/core version: 18.0.2
- @ngxs/store version: 16.0.0


Browser:
- [ x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@alexej-strelzow
Copy link

alexej-strelzow commented Jul 8, 2024

Is this repo still maintained @arturovt ?

@SanderBreivik
Copy link
Contributor

Any updates on this? @arturovt

@arturovt
Copy link
Member

6.0.0 has been published.

@alexej-strelzow
Copy link

thank you so much @arturovt !!!

@alexej-strelzow
Copy link

6.0.0 has been published.

@arturovt unfortunately the build is failing -> https://github.com/ngxs-labs/emitter/actions/runs/11516211565/job/32058429925

@arturovt
Copy link
Member

It's building locally.

@alexej-strelzow
Copy link

I believe you, maybe you need to remove the following command: yarn ngcc from https://github.com/ngxs-labs/emitter/blob/master/.yarnrc.yml (afterInstall) ?

see

==========================================

ALERT: As of Angular 16, "ngcc" is no longer required and not invoked during CLI builds. You are seeing this message because the current operation invoked the "ngcc" command directly. This "ngcc" invocation can be safely removed.

A common reason for this is invoking "ngcc" from a "postinstall" hook in package.json.

In Angular 17, this command will be removed. Remove this and any other invocations to prevent errors in later versions.

==========================================

@arturovt
Copy link
Member

You might consider doing it in a separate PR, as I currently don’t have the time to maintain this package.

@alexej-strelzow
Copy link

Not sure if this will solve the build problem, just thought you might give it a try? ngcc is not needed anymore anyway, so there is no harm in deleting that

@SanderBreivik
Copy link
Contributor

I created a PR @arturovt: PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants