Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Remove ngcc as it is not needed after angular 17 #790

Merged
merged 2 commits into from
Oct 26, 2024
Merged

fix(build): Remove ngcc as it is not needed after angular 17 #790

merged 2 commits into from
Oct 26, 2024

Conversation

SanderBreivik
Copy link
Contributor

@SanderBreivik SanderBreivik commented Oct 26, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Remove ngcc because it is not needed anymore
See issue here

What is the new behavior?

Removed ngcc

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@arturovt
Copy link
Member

CI failing

@SanderBreivik
Copy link
Contributor Author

Should be working again now @arturovt

@SanderBreivik
Copy link
Contributor Author

CI passing again

@arturovt arturovt merged commit 37c0c92 into ngxs-labs:master Oct 26, 2024
1 check passed
@SanderBreivik SanderBreivik deleted the v18-fix branch October 27, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants