Skip to content

Commit

Permalink
Revert "feat(store): expose ActionContext and ActionStatus (#1766)"
Browse files Browse the repository at this point in the history
This reverts commit e99e5ce.
(This has been reverted as part of pushing a patch release out with no new features)
  • Loading branch information
markwhitfeld committed Jun 8, 2022
1 parent f88f1ef commit 2da293f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
$ npm install @ngxs/store@dev
```

- Feature: Expose `ActionContext` and `ActionStatus` [#1766](https://github.com/ngxs/store/pull/1766)
- Feature: `ofAction*` methods should have strong types [#1808](https://github.com/ngxs/store/pull/1808)
- Build: include support for Angular 14 [#1850](https://github.com/ngxs/store/pull/1850)
- Fix: Do not re-use the global `Store` instance between different apps [#1740](https://github.com/ngxs/store/pull/1740) and [#1804](https://github.com/ngxs/store/pull/1804)
Expand Down
4 changes: 3 additions & 1 deletion packages/store/src/actions-stream.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ export class InternalActions extends OrderedSubject<ActionContext> {}
* You can listen to this in services to react without stores.
*/
@Injectable()
export class Actions extends Observable<ActionContext> {
export class Actions extends Observable<any> {
// This has to be `Observable<ActionContext>` in the v4. Because `InternalActions`
// is a `Subject<ActionContext>`. Leave it as `any` to avoid breaking changes
constructor(
internalActions$: InternalActions,
internalExecutionStrategy: InternalNgxsExecutionStrategy
Expand Down
2 changes: 1 addition & 1 deletion packages/store/src/public_api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export { Store } from './store';
export { State } from './decorators/state';
export { Select } from './decorators/select/select';
export { SelectorOptions } from './decorators/selector-options';
export { Actions, ActionContext, ActionStatus } from './actions-stream';
export { Actions } from './actions-stream';

// TODO: v4 - We need to come up with an alternative api to exposing this metadata
// because it is currently used by the following (after a github search):
Expand Down

0 comments on commit 2da293f

Please sign in to comment.