Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: handle async action scenarios #1663

Merged
merged 3 commits into from
May 18, 2021
Merged

Conversation

joaqcid
Copy link
Contributor

@joaqcid joaqcid commented Sep 6, 2020

I - Promise that returns an observable
II - Observable that returns a promise

PR Type

[ ] Other... Please describe: Test covering existing scenario

Issue Number: #1660

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ X] No

Other information

I - Promise that returns an observable
II - Observable that returns a promise
@splincode
Copy link
Member

@markwhitfeld any news?)

@splincode
Copy link
Member

@arturovt what do you mean about this?

@splincode
Copy link
Member

@arturovt do can we merge it?

Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documents the existing behaviour, which has a bug.
I wanted to change some test names, but this branch is in your repo.
I'll adjust it on master

@markwhitfeld
Copy link
Member

This has been fixed as part of the v3.7.4 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: NGXS @Actions don't handle an observable wrapped in a promise correctly
3 participants