Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(store): tree-shake ConfigValidator, HostEnvironment and isAngularInTestMode #1741

Merged
merged 1 commit into from
May 18, 2021
Merged

perf(store): tree-shake ConfigValidator, HostEnvironment and isAngularInTestMode #1741

merged 1 commit into from
May 18, 2021

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented May 2, 2021

No description provided.

@arturovt
Copy link
Member Author

arturovt commented May 2, 2021 •
edited
Loading

@markwhitfeld @splincode so I propose the following:

  1. Let's remove ConfigValidator and HostValidator. The HostValidator basically injects tokens (and nothing more). The ConfigValidator doesn't validate the config itself but rather verifies development mode.
  2. Let's move all checks to state-operations
  3. Deprecate the developmentMode property as proposed by @splincode

If the user is running Ivy:

  • then deepFreeze the state only when ngDevMode is truthy
  • we'll be able to tree-shake the deepFreeze in production mode

If the user is running View Engine:

  • use the isDevMode() function from @angular/core

@arturovt
Copy link
Member Author

@markwhitfeld friendly ping.

@markwhitfeld
Copy link
Member

@markwhitfeld @splincode so I propose the following:

  1. Let's remove ConfigValidator and HostValidator. The HostValidator basically injects tokens (and nothing more). The ConfigValidator doesn't validate the config itself but rather verifies development mode.
  2. Let's move all checks to state-operations
  3. Deprecate the developmentMode property as proposed by @splincode

If the user is running Ivy:

  • then deepFreeze the state only when ngDevMode is truthy
  • we'll be able to tree-shake the deepFreeze in production mode

If the user is running View Engine:

  • use the isDevMode() function from @angular/core

I'm happy with proposals 1 & 2.
Regarding proposal 3, we could add this to the list for v4. But I think we need to investigate if there are any valid use cases where the developmentMode and the ngDevMode would not align.

@markwhitfeld
Copy link
Member

@arturovt could you rebase this PR?

@arturovt arturovt force-pushed the perf/store branch 3 times, most recently from 7734e7d to afebb6c Compare May 18, 2021 13:44
@arturovt arturovt changed the title perf(store): tree-shake development mode message perf(store): tree-shake ConfigValidator, HostEnvironment and isAngularInTestMode May 18, 2021
@arturovt arturovt merged commit 8f72cfe into master May 18, 2021
@arturovt arturovt deleted the perf/store branch May 18, 2021 15:11
@markwhitfeld markwhitfeld added this to the v3.7.4 milestone Jun 10, 2022
@markwhitfeld markwhitfeld mentioned this pull request Jun 11, 2022
Closed
18 tasks
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jun 17, 2022
Update ngxs-store monorepo to v3.7.4 (#1401)
3c1d380 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@ngxs/form-plugin](https://github.com/ngxs/store) | dependencies | patch | [`3.7.3` -> `3.7.4`](https://renovatebot.com/diffs/npm/@ngxs%2fform-plugin/3.7.3/3.7.4) |
| [@ngxs/storage-plugin](https://github.com/ngxs/store) | dependencies | patch | [`3.7.3` -> `3.7.4`](https://renovatebot.com/diffs/npm/@ngxs%2fstorage-plugin/3.7.3/3.7.4) |
| [@ngxs/store](https://github.com/ngxs/store) | dependencies | patch | [`3.7.3` -> `3.7.4`](https://renovatebot.com/diffs/npm/@ngxs%2fstore/3.7.3/3.7.4) |

---

### Release Notes

<details>
<summary>ngxs/store</summary>

### [`v3.7.4`](https://github.com/ngxs/store/blob/HEAD/CHANGELOG.md#&#8203;374-2022-06-09)

[Compare Source](ngxs/store@v3.7.3...v3.7.4)

-   Build: include support for Angular 14 [#&#8203;1850](ngxs/store#1850)
-   Fix: Do not re-use the global `Store` instance between different apps [#&#8203;1740](ngxs/store#1740) and [#&#8203;1804](ngxs/store#1804)
-   Fix: Handle mixed async scenarios for action handlers [#&#8203;1762](ngxs/store#1762)
-   Fix: An action with cancelUncompleted enabled should unsubscribe before the next action handler is called [#&#8203;1763](ngxs/store#1763)
-   Fix: Do not run `Promise.then` within synchronous tests when decorating factory [#&#8203;1753](ngxs/store#1753)
-   Fix: Provide `NoopNgxsExecutionStrategy` explicitly when the zone is nooped [#&#8203;1819](ngxs/store#1819)
-   Fix: Complete the state stream once the root view is removed [#&#8203;1830](ngxs/store#1830)
-   Fix: Be more explicit when checking if Angular is in test mode [#&#8203;1831](ngxs/store#1831), [#&#8203;1832](ngxs/store#1832)
-   Fix: Devtools Plugin - Do not connect to devtools when the plugin is disabled [#&#8203;1761](ngxs/store#1761)
-   Fix: Router Plugin - Cleanup subscriptions when the root view is destroyed [#&#8203;1754](ngxs/store#1754)
-   Fix: WebSocket Plugin - Cleanup subscriptions and close the connection when the root view is destroyed [#&#8203;1755](ngxs/store#1755)
-   Fix: Storage Plugin - Only restore state if key matches `addedStates` [#&#8203;1746](ngxs/store#1746)
-   Fix: Forms Plugin - Do not destructure primitive types [#&#8203;1845](ngxs/store#1845)
-   Performance: Tree-shake errors and warnings [#&#8203;1732](ngxs/store#1732)
-   Performance: Tree-shake `ConfigValidator`, `HostEnvironment` and `isAngularInTestMode` [#&#8203;1741](ngxs/store#1741)
-   Performance: Tree-shake `SelectFactory` [#&#8203;1744](ngxs/store#1744)
-   Performance: Tree-shake `deepFreeze` [#&#8203;1819](ngxs/store#1819)
-   Performance: Run change detection once for all selectors when asynchronous action has been completed [#&#8203;1828](ngxs/store#1828)
-   Performance: Router Plugin - Tree-shake `isAngularInTestMode()` [#&#8203;1738](ngxs/store#1738)
-   Performance: Tree-shake `isAngularInTestMode()` [#&#8203;1739](ngxs/store#1739)
-   Performance: Storage Plugin - Tree-shake `console.*` calls and expand error messages [#&#8203;1727](ngxs/store#1727)
-   CI: Bundlesize checks should run reliably [#&#8203;1812](ngxs/store#1812)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1401
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode left review comments

@markwhitfeld markwhitfeld markwhitfeld approved these changes

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
v3.7.4
Development

Successfully merging this pull request may close these issues.
3 participants
@arturovt @markwhitfeld @splincode