Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(store): add initial version of new strongly typed createSelector #1823

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

markwhitfeld
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The current createSelector uses any in its typing and does not calculate the return type correctly.

What is the new behavior?

This PR is the first step to introducing an improvement to those typings.
The improved createSelector is added here without exporting it to enable some other concurrent work in other PRs.
There will be a separate PR that adds the type tests for this as well as replacing the previous loosely typed version.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@markwhitfeld markwhitfeld merged commit 90fdd58 into master Feb 9, 2022
@markwhitfeld markwhitfeld deleted the chore/add-initial-create-selector-typings branch February 9, 2022 12:28
@markwhitfeld
Copy link
Member Author

Sorry to merge this with no review, but this is essentially a noop PR on the repo at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant