build: add angular 17 support

[jpraetorius]

• extend allowed range of ng peer dependency to 18
• add an additional integration test for NG17 with updated dependencies and tests.
• add additional test in all places the other tests run

fixes #2078

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngxs/store/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Updating an application using ngxs to Angular 17 fails, because all the packages declare < 17 as the range for their peer dependency

Issue Number: #2078

What is the new behavior?

Updating to Angular 17 works, the range of allowed Angular versions has been adapted to <18. Compatibility has been checked with an additional integration test.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Note that I first started by updating the dependencies for Angular to 17 too – that however results in a compile Error for the Angular 15 integration test, which is why I opted to not follow up on that change. The adaptation of custom-rxjs-subject below stems from that though (Updating Angular implies updating Typescript and the compiler complains about not being able to assert the type of <T> which made the explicit cast necessary.
I left that particular change in the commit, as I think it causes no harm and helps for further updates.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8011d01. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 3 targets

• nx run-many --target=test --all --configuration=ci --maxWorkers=4
• nx run-many --target=lint --all
• nx run-many --target=build --all

---

Sent with 💌 from NxCloud.

[jpraetorius]

For all I can gather about the error this seems to be related to old(ish) yarn.lock versions that might keep old browserslist configurations around. I don't know if you folks have a way of bypassing the cache for this build?
(I don't want to just update, as I get your reasoning why you check the file in and keep the cache for the build).

[codeclimate]

Code Climate has analyzed commit 8011d01 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.5% (0.5% change).

View more on Code Climate.

[bundlemon]

BundleMon (Integration Projects)

Unchanged files (1)

Status	Path	Size	Limits
✅	Main bundles(Gzip) hello-world-ng15/dist-integration/main.(hash) .js	63.35KB	+1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[monabbous]

Will this be reviewed soon?

@kuncevic @Carniatto @markwhitfeld @poloagustin @joaqcid @arturovt @splincode

[markwhitfeld]

Yes, my plan was to release today, but we have had a massive fibre break in the area and I am without internet. Hopefully tomorrow the release will be going out.

…

On Wed, 22 Nov 2023 at 21:34, Mohamed Nabous ***@***.***> wrote: Will this be reviewed soon? @kuncevic <https://github.com/kuncevic> @Carniatto <https://github.com/Carniatto> @markwhitfeld <https://github.com/markwhitfeld> @poloagustin <https://github.com/poloagustin> @joaqcid <https://github.com/joaqcid> @arturovt <https://github.com/arturovt> @splincode <https://github.com/splincode> — Reply to this email directly, view it on GitHub <#2079 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO3U2LALMVDZSR4GN63JO3YFZHV7AVCNFSM6AAAAAA7EQDWOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRTGQYDGMBSGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ggros-septeo]

Yes, my plan was to release today, but we have had a massive fibre break in the area and I am without internet. Hopefully tomorrow the release will be going out.

Thanks for you time!

[Sina7312]

When does this get published on npm? @markwhitfeld

[frasermclean]

Keen to add this to a new Angular 17 project

[CesarD]

Same here!! 😅

[frasermclean]

Same here!! 😅

Seems like its good to go now. 3.8.2 is out

[danielbraghini]

any news about it?

[jpraetorius]

@danielbraghini as the timeline above shows this landed in 3.8.2