Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade workspace to Angular 17 #2087

Merged
merged 10 commits into from
Feb 5, 2024
Merged

feat: upgrade workspace to Angular 17 #2087

merged 10 commits into from
Feb 5, 2024

Conversation

arturovt
Copy link
Member

No description provided.

@markwhitfeld
Copy link
Member

@arturovt I see that there is quite a bit of reformatting of files in this PR.
Could you split that reformatting work into a separate PR to make this one easier to review?

@arturovt
Copy link
Member Author

@markwhitfeld I have reverted formatting changes.

Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is so much going on in this PR that it was super difficult to review.
I have a number of suggested changes and questions.
If it is easy to split this into smaller PRs then that would be awesome. If not, then let's press ahead to try to get this PR in.

integration/app/app.component.ts Outdated Show resolved Hide resolved
integration/app/app.config.ts Outdated Show resolved Hide resolved
integration/jest.config.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.github/workflows/trunk.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/pr-validation.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/trunk.yml Outdated Show resolved Hide resolved
@arturovt arturovt changed the title feat: upgrade to Angular 17, add selectSignal feat: upgrade to Angular 17 Feb 1, 2024
@arturovt arturovt changed the title feat: upgrade to Angular 17 feat: upgrade workspace to Angular 17 Feb 1, 2024
Copy link

bundlemon bot commented Feb 1, 2024

BundleMon (Integration Projects)

Files added (2)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
+67.4KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
+65.9KB +1%
Files removed (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng15/dist-integration/main.(hash)
.js
-63.35KB +1%

Total files change +69.96KB +110.44%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@arturovt arturovt marked this pull request as ready for review February 1, 2024 17:11
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in principle, but we should not merge this until we are building towards the next release that drops support for ng15 and earlier.

@markwhitfeld markwhitfeld marked this pull request as draft February 5, 2024 21:13
Copy link

nx-cloud bot commented Feb 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f3de765. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@markwhitfeld markwhitfeld marked this pull request as ready for review February 5, 2024 21:50
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a deeper review, and it doesn't look like this will affect our supported Angular versions.

@markwhitfeld markwhitfeld merged commit ac99a18 into master Feb 5, 2024
11 checks passed
@markwhitfeld markwhitfeld deleted the ng-16 branch February 5, 2024 22:04
@markwhitfeld markwhitfeld added this to the v.18.0.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants