-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade workspace to Angular 17 #2087
Conversation
@arturovt I see that there is quite a bit of reformatting of files in this PR. |
4ee6950
to
e0c4bc7
Compare
@markwhitfeld I have reverted formatting changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is so much going on in this PR that it was super difficult to review.
I have a number of suggested changes and questions.
If it is easy to split this into smaller PRs then that would be awesome. If not, then let's press ahead to try to get this PR in.
selectSignal
BundleMon (Integration Projects)Files added (2)
Files removed (1)
Total files change +69.96KB +110.44% Final result: ✅ View report in BundleMon website ➡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in principle, but we should not merge this until we are building towards the next release that drops support for ng15 and earlier.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f3de765. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a deeper review, and it doesn't look like this will affect our supported Angular versions.
No description provided.