Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(storage-plugin): use ngServerMode to check whether we are in SSR #2288

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Dec 24, 2024

In this commit, we replace isPlatformServer in the storage plugin with the new built-in variable
ngServerMode, available starting from Angular 19.
This compile-time variable allows the code to be tree-shakable.

Copy link

nx-cloud bot commented Dec 24, 2024

View your CI Pipeline Execution ↗ for commit 4c55044.

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 33s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 2s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 36s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-24 15:02:41 UTC

Copy link

pkg-pr-new bot commented Dec 24, 2024

Open in Stackblitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2288

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2288

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2288

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2288

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2288

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2288

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2288

commit: 4c55044

Copy link

bundlemon bot commented Dec 24, 2024

BundleMon

Unchanged files (6)
Status Path Size Limits
fesm2022/ngxs-store.mjs
104.56KB 105KB / +0.5%
fesm2022/ngxs-store-internals.mjs
11.51KB 13KB / +0.5%
fesm2022/ngxs-store-internals-testing.mjs
6.8KB 7KB / +0.5%
fesm2022/ngxs-store-operators.mjs
6.22KB 7KB / +0.5%
fesm2022/ngxs-store-plugins.mjs
2.38KB 3KB / +0.5%
fesm2022/ngxs-store-experimental.mjs
574B 2KB / +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
@ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
31.85KB +1%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Dec 24, 2024

BundleMon (NGXS Plugins)

Files updated (1)
Status Path Size Limits
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
3.98KB (-59B -1.43%) +0.5%
Unchanged files (8)
Status Path Size Limits
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
3.01KB +0.5%
Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
2.61KB +0.5%
Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
2.57KB +0.5%
Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
2.46KB +0.5%
Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
2.14KB +0.5%
Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
2.01KB +0.5%
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
861B +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
396B +0.5%

Total files change -59B -0.29%

Groups updated (1)
Status Path Size Limits
All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
19.99KB (-59B -0.29%) +0.5%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Dec 24, 2024

BundleMon (Integration Projects)

Files added (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng19/dist-integration/browser/mai
n-(hash).js
+66.33KB +1%
Files removed (3)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng18/dist-integration/browser/mai
n-(hash).js
-70.1KB +1%
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
-68.24KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
-67.3KB +1%

Total files change -139.31KB -67.74%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@arturovt arturovt force-pushed the build/storage-server branch 2 times, most recently from 3764c6b to 3881273 Compare December 24, 2024 14:56
In this commit, we replace `isPlatformServer` in the storage plugin with the new built-in variable
`ngServerMode`, available starting from Angular 19.
This compile-time variable allows the code to be tree-shakable.
@arturovt arturovt force-pushed the build/storage-server branch from 3881273 to 4c55044 Compare December 24, 2024 14:58
Copy link

codeclimate bot commented Dec 24, 2024

Code Climate has analyzed commit 4c55044 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

@arturovt arturovt marked this pull request as ready for review December 24, 2024 15:21
@arturovt arturovt merged commit 26bd22b into master Dec 24, 2024
15 of 16 checks passed
@arturovt arturovt deleted the build/storage-server branch December 24, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant