-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(storage-plugin): use ngServerMode
to check whether we are in SSR
#2288
Conversation
View your CI Pipeline Execution ↗ for commit 4c55044.
☁️ Nx Cloud last updated this comment at |
@ngxs/devtools-plugin
@ngxs/form-plugin
@ngxs/hmr-plugin
@ngxs/router-plugin
@ngxs/storage-plugin
@ngxs/store
@ngxs/websocket-plugin
commit: |
BundleMonUnchanged files (6)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Files updated (1)
Unchanged files (8)
Total files change -59B -0.29% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files added (1)
Files removed (3)
Total files change -139.31KB -67.74% Final result: ✅ View report in BundleMon website ➡️ |
3764c6b
to
3881273
Compare
In this commit, we replace `isPlatformServer` in the storage plugin with the new built-in variable `ngServerMode`, available starting from Angular 19. This compile-time variable allows the code to be tree-shakable.
3881273
to
4c55044
Compare
Code Climate has analyzed commit 4c55044 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
In this commit, we replace
isPlatformServer
in the storage plugin with the new built-in variablengServerMode
, available starting from Angular 19.This compile-time variable allows the code to be tree-shakable.