Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace ngOnDestroy with DestroyRef #2289

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

arturovt
Copy link
Member

No description provided.

Copy link

nx-cloud bot commented Dec 24, 2024

View your CI Pipeline Execution ↗ for commit fc3f984.

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 47s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 2s View ↗
nx run-many --target=build --all ✅ Succeeded 39s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-24 17:41:58 UTC

Copy link

pkg-pr-new bot commented Dec 24, 2024

Open in Stackblitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2289

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2289

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2289

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2289

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2289

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2289

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2289

commit: fc3f984

Copy link

bundlemon bot commented Dec 24, 2024

BundleMon

Files updated (2)
Status Path Size Limits
fesm2022/ngxs-store.mjs
104.78KB (+224B +0.21%) 105KB / +0.5%
fesm2022/ngxs-store-internals.mjs
11.54KB (+30B +0.25%) 13KB / +0.5%
Unchanged files (4)
Status Path Size Limits
fesm2022/ngxs-store-internals-testing.mjs
6.8KB 7KB / +0.5%
fesm2022/ngxs-store-operators.mjs
6.22KB 7KB / +0.5%
fesm2022/ngxs-store-plugins.mjs
2.38KB 3KB / +0.5%
fesm2022/ngxs-store-experimental.mjs
574B 2KB / +0.5%

Total files change +254B +0.19%

Groups updated (1)
Status Path Size Limits
@ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
31.89KB (+33B +0.1%) +1%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Dec 24, 2024

BundleMon (NGXS Plugins)

Files updated (1)
Status Path Size Limits
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
3.02KB (+11B +0.36%) +0.5%
Unchanged files (8)
Status Path Size Limits
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
3.98KB +0.5%
Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
2.61KB +0.5%
Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
2.57KB +0.5%
Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
2.46KB +0.5%
Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
2.15KB +0.5%
Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
2.01KB +0.5%
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
861B +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
396B +0.5%

Total files change +21B +0.1%

Groups updated (1)
Status Path Size Limits
All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
20.01KB (+21B +0.1%) +0.5%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Dec 24, 2024

BundleMon (Integration Projects)

Files added (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng19/dist-integration/browser/mai
n-(hash).js
+66.35KB +1%
Files removed (3)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng18/dist-integration/browser/mai
n-(hash).js
-70.1KB +1%
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
-68.24KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
-67.3KB +1%

Total files change -139.3KB -67.74%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@arturovt arturovt force-pushed the refactor/destroyref branch from a5af8f0 to fc3f984 Compare December 24, 2024 17:37
Copy link

codeclimate bot commented Dec 24, 2024

Code Climate has analyzed commit fc3f984 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

@arturovt arturovt marked this pull request as ready for review December 24, 2024 17:48
@arturovt arturovt merged commit ee2db76 into master Dec 24, 2024
16 checks passed
@arturovt arturovt deleted the refactor/destroyref branch December 24, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant