Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to disable ALL gremlins (useful for language-overrides) #160

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

TheSench
Copy link
Collaborator

@TheSench TheSench commented Nov 6, 2020

Description

This PR adds a gremlins.disabled configuration that allows all processing to be disabled. This setting is intended to be used with language-specific configurations so that gremlins can be completely ignored for files of a specific type.

Motivation and Context

This builds upon the language-specific configuration and allows ALL gremlins to be disabled for a given language without needing to manually override each of them individually.

How Has This Been Tested?

This has been tested using both manual and unit tests. I have tested turning the setting on to confirm that no gremlins are processed. Additionally, I have tested turning it on for a specific language, as well as turning it on globally, and then off for a specific language. In all cases, the expected behavior has been observed.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant