-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/detect settings changes (Fixes #56) #57
Merged
nhoizey
merged 15 commits into
nhoizey:master
from
TheSench:feature/detect-settings-changes
Nov 4, 2019
Merged
Feature/detect settings changes (Fixes #56) #57
nhoizey
merged 15 commits into
nhoizey:master
from
TheSench:feature/detect-settings-changes
Nov 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhoizey
reviewed
Oct 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks great.
I just made 2 comments to understand what/why you did it.
TheSench
commented
Oct 29, 2019
nhoizey
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following changes:
Fixes #56
Motivation and Context
The current implementation does not update when configuration settings are changed. Any changes require a reload of VSCode before they take effect. This change updates the extension to listen for settings changes and then resets its in-memory configuration.
Additionally, during testing, it was discovered that several Disposable items were not being disposed of. This normally doesn't cause any issues, as the extension is usually only deactivated when VSCode is closed. When working with setting changes though, this runs into issues with the decorations - recreating decorations without disposing of the old ones causes the decoration changes to not actually show up (e.g. changing the gremlin icon size).
How Has This Been Tested?
This has been tested via unit tests and manual testing.
Screenshots (if appropriate):
Types of changes
Checklist: