Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

Feature/RT-81 Persistence Adapter #44

Merged
merged 20 commits into from
Aug 8, 2019
Merged

Feature/RT-81 Persistence Adapter #44

merged 20 commits into from
Aug 8, 2019

Conversation

flavgj
Copy link
Contributor

@flavgj flavgj commented Aug 1, 2019

Please ignore the branch name typo.

@flavgj flavgj changed the title Feature/rt 81 persistence adaptor Feature/RT-81 Persistence Adapter Aug 1, 2019
Philip-Woods
Philip-Woods reviewed Aug 1, 2019
View reviewed changes
mhs/mhs/common/state/dynamo_persistence_adapter.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/dynamo_persistence_adapter.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/dynamo_persistence_adapter.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/dynamo_persistence_adapter.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/persistence_adapter.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/persistence_adapter.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/persistence_adapter.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/tests/test_dynamo_persistence_adaoter.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/tests/test_dynamo_persistence_adaoter.py Outdated Show resolved Hide resolved
Philip-Woods
Philip-Woods reviewed Aug 2, 2019
View reviewed changes
Copy link
Contributor

@Philip-Woods Philip-Woods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will give it a 👍 when it goes through the pipeline

@ismail-s
Copy link
Contributor

ismail-s commented Aug 2, 2019

@flavgj pypa/pip#2984 probably was causing this memory issue. Though I expect that the cache helps us a bit as we run pipenv multiple times.

ismail-s
ismail-s suggested changes Aug 2, 2019
View reviewed changes
mhs/mhs/common/state/dynamo_persistence_adaptor.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/dynamo_persistence_adaptor.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/persistence_adaptor.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/persistence_adaptor.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/dynamo_persistence_adaptor.py Show resolved Hide resolved
mhs/mhs/common/state/tests/test_dynamo_persistence_adaptor.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/tests/test_dynamo_persistence_adaptor.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/tests/test_dynamo_persistence_adaptor.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/tests/test_dynamo_persistence_adaptor.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/tests/test_dynamo_persistence_adaptor.py Outdated Show resolved Hide resolved
@Philip-Woods Philip-Woods mentioned this pull request Aug 5, 2019
Merged
ismail-s
ismail-s previously approved these changes Aug 6, 2019
View reviewed changes
Philip-Woods
Philip-Woods previously approved these changes Aug 6, 2019
View reviewed changes
ismail-s
ismail-s previously approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@ismail-s ismail-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think enough's done for me to approve. Comments have some suggestions though.

mhs/mhs/common/state/dynamo_persistence_adaptor.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/tests/test_dynamo_persistence_adaptor.py Outdated Show resolved Hide resolved
mhs/mhs/common/state/tests/test_dynamo_persistence_adaptor.py Show resolved Hide resolved
mhs/mhs/common/state/tests/test_dynamo_persistence_adaptor.py Show resolved Hide resolved
@flavgj flavgj merged commit 2d6a71e into develop Aug 8, 2019
@flavgj flavgj deleted the feature/RT-81-persistance-adaptor branch August 8, 2019 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ismail-s ismail-s ismail-s approved these changes

@Philip-Woods Philip-Woods Philip-Woods left review comments

Assignees

@ismail-s ismail-s

@Philip-Woods Philip-Woods

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flavgj @ismail-s @Philip-Woods @bjss-GuyFlavell