Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vireo npm development dependencies #680

Merged
merged 3 commits into from
Jan 28, 2021
Merged

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented Jan 22, 2021

Updates Vireo's build tooling JS packages to the latest versions.

The karma-jasmine and jasmine-core packages were not updated to the latest versions due to behavior changes in jasmine-core for unhandledrejection events. See: jasmine/jasmine#1843

In addition, karma was not updated to the latest version as it breaks the karma-jasmine-spec-tags plugin. See: mnasyrov/karma-jasmine-spec-tags#12

ASW PR with local build results.

Due to behavior changes in jasmine-core for unhandledrejection events revert to an older karma-jasmine and jasmine-core version.
See: jasmine/jasmine#1843
@rajsite rajsite requested a review from cglzaguilar as a code owner January 22, 2021 04:43
Copy link
Contributor

@cglzaguilar cglzaguilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for working on this!

@rajsite rajsite merged commit 2d57c25 into ni:main Jan 28, 2021
@rajsite rajsite deleted the deps-update branch January 28, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants