Split API code for LTE Bluetooth and WLAN #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulBenaka
requested review from
reckenro,
astarche and
maxxboehme
as code owners
maxxboehme
approved these changes
Sep 19, 2024
reckenro
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Added new Split APIs for niRFmxLTE
Added new Split APIs for niRFmxBluetooth
Added new Split APIs for niRFmxWLAN
Reference PR: #1090
Why should this Pull Request be merged?
Adding Split APIs for niRFmxLTE, niRFmxBluetooth and niRFmxWLAN as part of WI: as part of the WI: https://dev.azure.com/ni/DevCentral/_workitems/edit/2820766
What testing has been done?
Copied files from grpc-device-scrapigen/out/rfmxlte/export/ to grpc-device/source/codegen/metadata/nirfmxlte/ and built grpc-device successfully.
Manually inspected nirfmxlte.proto file.
Copied files from grpc-device-scrapigen/out/rfmxbluetooth/export/ to grpc-device/source/codegen/metadata/nirfmxbluetooth/ and built grpc-device successfully.
Manually inspected nirfmxbluetooth.proto file.
Copied files from grpc-device-scrapigen/out/rfmxwlan/export/ to grpc-device/source/codegen/metadata/nirfmxwlan/ and built grpc-device successfully.
Manually inspected nirfmxwlan.proto file.