Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming API for remaining FPGA functions. #1118

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

amehra-ni
Copy link
Contributor

@amehra-ni amehra-ni commented Nov 13, 2024

What does this Pull Request accomplish?

This PR adds support for the remaining FPGA APIs.

Why should this Pull Request be merged?

  • Added necessary message in custom_proto.
  • Updated functions.py list with the leftover functions.
  • Updated to ${streaming_type} value {}; (as done for normal functions )such that it fits all datatype initialization.
  • Initialize vector properly as when we call array_storage.data(), it returns a pointer to the underlying array, but since the vector is empty, this pointer is not valid for writing. Hence, initialize it properly now with the size.
  • Updated the ownership transfer of the pointer using release() now for the data variable.

What testing has been done?

Streaming functions get called correctly, and the data is read/written correctly. This is one example where I read/write data in an indicator in the loop. (I have tested this for normal i32 type, but it will still work for other types as implementation is same internally) This is for scaler.
image
This is for array.
image

@amehra-ni amehra-ni marked this pull request as ready for review November 13, 2024 18:48
@amehra-ni amehra-ni requested a review from maxxboehme November 13, 2024 18:48
@amehra-ni amehra-ni merged commit 248ba4f into main Nov 14, 2024
9 of 10 checks passed
@amehra-ni amehra-ni deleted the users/amehra/leftover-fpga-streaming branch November 14, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants