Add missing DAQmx AnalogStatesWithOutputType functions #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 22, 2021 16:15
gregstoll
commented
Oct 25, 2021
gregstoll
commented
Oct 25, 2021
astarche
reviewed
Oct 25, 2021
astarche
reviewed
Oct 25, 2021
astarche
reviewed
Oct 25, 2021
astarche
reviewed
Oct 25, 2021
astarche
requested changes
Oct 25, 2021
astarche
reviewed
Oct 25, 2021
astarche
added
the
binary-breaking
astarche
approved these changes
Oct 25, 2021
reckenro
approved these changes
Oct 26, 2021
gregstoll
deleted the
users/gstoll/daq-missing-analogpowerupstates-functions
branch
astarche
added a commit
to astarche/grpc-device
that referenced
this pull request
Oct 26, 2021
…ed-complex * upstream/main: add validation that there's only one set of ivi-dance-with-a-twist sizes and twists (ni#410) Increase server max message size. (ni#409) Add missing DAQmx AnalogStatesWithOutputType functions (ni#408) Add missing defines from RFSA/G (ni#400) Add NI-RFSA getting started examples (ni#406) Fix wrong enum string in RFSG (ni#405) Remove LockSession and UnlockSession from services (ni#403) remove redundant suffixes from RFSG enum names and values (ni#397) Fixup RFSA enum names (ni#393) remove "Attr" from RFSG attribute enum names (ni#392)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds missing functions.
GetAnalogPowerUpStatesWithOutputType()uses an output array sizing mechanism we haven't seen before - the size of the array is passed in by pointer, and the underlying API method sets that pointer to the actual size. If the actual size is bigger than what is passed in, the method returns an error. So this change adds a new mechanismpassed-in-by-ptr.Breaking change: Input arrays on Watchdog ExpirStates methods are given enum types, replacing int32 fields. Requires source changes, but does not break binary compatibility other than restricting valid values.
Why should this Pull Request be merged?
Adds two missing DAQmx methods.
What testing has been done?
Added some unit tests for the new mechanism.