Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Updates the niRFmxWlan service to the latest public API (version 22.5). A handful of functions, attributes, and enums were added.
Breaking change:
The following attribute has been renamed:
NIRFMXWLAN_ATTRIBUTE_OFDMMODACC_CHANNEL_ESTIMATION_INTERPOLATION_TYPE
replacesNIRFMXWLAN_ATTRIBUTE_OFDMMODACC_CHANNEL_ESTIMATION_SMOOTHING_ENABLED
To accommodate new enum values:
NIRFMXWLAN_INT32_OFDMMODACC_CHANNEL_ESTIMATION_INTERPOLATION_TYPE_LINEAR = 0
NIRFMXWLAN_INT32_OFDMMODACC_CHANNEL_ESTIMATION_INTERPOLATION_TYPE_TRIANGULAR_SMOOTHING = 1
NIRFMXWLAN_INT32_OFDMMODACC_CHANNEL_ESTIMATION_INTERPOLATION_TYPE_WIENER_FILTER = 2
And the following enums have been removed:
NIRFMXWLAN_INT32_OFDMMODACC_CHANNEL_ESTIMATION_SMOOTHING_ENABLED_FALSE = 0
NIRFMXWLAN_INT32_OFDMMODACC_CHANNEL_ESTIMATION_SMOOTHING_ENABLED_TRUE = 1
Existing source code wishing to compile against the updated
nirfmxwlan.proto
will need to update any references toSMOOTHING_ENABLED
to use the newINTERPOLATION_TYPE
, but existing binaries should work.Why should this Pull Request be merged?
To support applications under development that use grpc and the latest version of RFmx.
What testing has been done?
Built and ran tests. All system tests passed except two that always fail on my test machine: