Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update niRFmxWlan to 22.5 #706

Merged
merged 5 commits into from
Aug 24, 2022

Conversation

Wedgetable
Copy link
Contributor

What does this Pull Request accomplish?

Updates the niRFmxWlan service to the latest public API (version 22.5). A handful of functions, attributes, and enums were added.

Breaking change:
The following attribute has been renamed:

  • NIRFMXWLAN_ATTRIBUTE_OFDMMODACC_CHANNEL_ESTIMATION_INTERPOLATION_TYPE replaces NIRFMXWLAN_ATTRIBUTE_OFDMMODACC_CHANNEL_ESTIMATION_SMOOTHING_ENABLED

To accommodate new enum values:

  • NIRFMXWLAN_INT32_OFDMMODACC_CHANNEL_ESTIMATION_INTERPOLATION_TYPE_LINEAR = 0
  • NIRFMXWLAN_INT32_OFDMMODACC_CHANNEL_ESTIMATION_INTERPOLATION_TYPE_TRIANGULAR_SMOOTHING = 1
  • NIRFMXWLAN_INT32_OFDMMODACC_CHANNEL_ESTIMATION_INTERPOLATION_TYPE_WIENER_FILTER = 2

And the following enums have been removed:

  • NIRFMXWLAN_INT32_OFDMMODACC_CHANNEL_ESTIMATION_SMOOTHING_ENABLED_FALSE = 0
  • NIRFMXWLAN_INT32_OFDMMODACC_CHANNEL_ESTIMATION_SMOOTHING_ENABLED_TRUE = 1

Existing source code wishing to compile against the updated nirfmxwlan.proto will need to update any references to SMOOTHING_ENABLED to use the new INTERPOLATION_TYPE, but existing binaries should work.

Why should this Pull Request be merged?

To support applications under development that use grpc and the latest version of RFmx.

What testing has been done?

Built and ran tests. All system tests passed except two that always fail on my test machine:

[  FAILED  ] 2 tests, listed below:
[  FAILED  ] SessionUtilitiesServiceTests.SysCfgLibraryPresent_EnumerateDevices_DevicePropertiesIncludesNameModelVendorSerialNumberProductId
[  FAILED  ] NiDCPowerDriverApiTest.CalSelfCalibrate_CompletesSuccessfully

Signed-off-by: KC Hawes-Domingue 🦜 <[email protected]>
Signed-off-by: KC Hawes-Domingue 🦜 <[email protected]>
Signed-off-by: KC Hawes-Domingue 🦜 <[email protected]>
Signed-off-by: KC Hawes-Domingue 🦜 <[email protected]>
@Wedgetable Wedgetable added the binary-breaking Change to proto file that requires client updates label Aug 18, 2022
@Wedgetable Wedgetable merged commit 93271b8 into ni:main Aug 24, 2022
@Wedgetable Wedgetable deleted the users/khawesdo/update-nirfmxwlan-22.5 branch August 24, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary-breaking Change to proto file that requires client updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants