Add enumerate_software functionality #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wedgetable
requested review from
reckenro,
astarche and
SparkingSpork
as code owners
astarche
approved these changes
Oct 26, 2022
reckenro
approved these changes
Oct 26, 2022
SparkingSpork
approved these changes
Oct 26, 2022
Wedgetable
commented
Oct 31, 2022
# Conflicts: # CMakeLists.txt # source/server/session_utilities_service.cpp # source/server/session_utilities_service.h # source/server/session_utilities_service_registrar.cpp # source/server/syscfg_library.cpp # source/server/syscfg_library.h # source/server/syscfg_library_interface.h # source/tests/unit/device_enumerator_tests.cpp # source/tests/utilities/syscfg_mock_library.h
dmondrik
reviewed
Nov 3, 2022
dmondrik
reviewed
Nov 3, 2022
dmondrik
reviewed
Nov 3, 2022
dmondrik
approved these changes
Nov 3, 2022
…idden_packages parameter
dmondrik
reviewed
Nov 3, 2022
…separate request/response
|
We could avoid having a separate example for this function. I recommend combining it with device enumeration example & rename it appropriately. That way, going ahead, when we add more sys config functions, we can just put them in the same example. |
harsha-bhushan
approved these changes
Nov 4, 2022
Actually for the example, I'd either not specify it, or make it False. Most users would care only about the visible packages. |
dmondrik
reviewed
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Similar to
enumerate_devices, this uses the NI System Configuration API to find NI software on the server and enables clients to get a list of these packages.I'm still pretty new to this codebase, so I based my implementation heavily on that of the existing
enumerate_devicesfunctionality. Feel free to point out methods that could/should be shared, or other places that are too copy/pasta-ish.Why should this Pull Request be merged?
Enables applications to check for certain packages and versions on the remote server - drivers especially - in order to know what functionality is available.
What testing has been done?
SoftwareEnumeratorclass and ran themDeviceEnumeratorand ran themenumerate-softwareexample and used it to get a list of NI packages off a remote machine runningni_grpc_device_server