Add additional metadata to NIDAQmx errors #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested changes
May 10, 2023
bkeryan
reviewed
May 11, 2023
reckenro
reviewed
May 12, 2023
reckenro
reviewed
May 12, 2023
reckenro
approved these changes
May 12, 2023
bkeryan
requested changes
May 12, 2023
astarche
approved these changes
May 15, 2023
bkeryan
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR updates the
readandwritemethods in NIDAQmx to send additional metadata when an error occurs.
readmethods, additionallysamps_per_chan_readwill be added to the error info.writemethods, additionallysamps_per_chan_wrtitenwill be added to the error info.Why should this Pull Request be merged?
Implements Task 2323110: Update the nidaqmx gRPC server to return RPC exceptions with data on the number of samples read/written in a read/write operation.
What testing has been done?
Manually generated the files and verified the changes made.